Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Specification to Spec, or rename function to Specification? #205

Closed
bufdev opened this issue Apr 22, 2022 · 2 comments · Fixed by #208
Closed

Rename Specification to Spec, or rename function to Specification? #205

bufdev opened this issue Apr 22, 2022 · 2 comments · Fixed by #208

Comments

@bufdev
Copy link
Member

bufdev commented Apr 22, 2022

No description provided.

@akshayjshah
Copy link
Member

I'll rename the type. Calling Specification() for something common is terrible.

@bufdev
Copy link
Member Author

bufdev commented Apr 28, 2022

sgtm

akshayjshah added a commit that referenced this issue May 6, 2022
@akshayjshah
Rename Specification -> Spec
4337a66 
Fixes #205.
@akshayjshah akshayjshah mentioned this issue May 6, 2022
Merged
akshayjshah added a commit that referenced this issue May 6, 2022
@akshayjshah
Rename Specification -> Spec (#208)
9161c3d 
Fixes #205.
akshayjshah added a commit that referenced this issue Jul 26, 2023
@akshayjshah
Rename Specification -> Spec (#208)
2a55751 
Fixes #205.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Specification -> Spec connectrpc/connect-go
2 participants
@akshayjshah @bufdev