Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REV: Add high-level paper summary #175

Merged
merged 8 commits into from
Jun 11, 2022

Conversation

sebastientourbier
Copy link
Member

@sebastientourbier sebastientourbier commented Apr 30, 2022

PR related to JOSS review: openjournals/joss-reviews#4248

This PR resolves #161.

It addresses issue point 2) by adding in the paper the suggested high-level summary.

It addresses issue points 2 and 3 by renaming the following sections:

  • "Summary" -> "Design and functionality overview"
  • "Mention" -> "Community impact"

Finally, the sections "Outputs ready to be reused in the BIDS ecosystem" and "A focus on accessibility and versatility" have been swapped to improve the rendering of the compiled PDF.

Generation of the PDF of the most updated draft could done with https://whedon.theoj.org/ as follows:
Screen Shot 2022-06-02 at 10 40 24

@sebastientourbier
Copy link
Member Author

sebastientourbier commented May 9, 2022

Dear co-authors/contributors,

Hope you are doing well!

CMP3's review is on going, and while I can take care of most of the points that are very software/docs related, I would need your feedback on this.

In fact in response to the following comment:

The JOSS guidelines state that the paper should have "A summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience". At the moment, the summary section makes out the bulk of the paper, and I consider much of it to be quite detailed and specialist. I don't think this content is a problem though, just that I'm missing a shorter summary for a diverse, non-specialist audience. Perhaps a new paragraph could be included to serve as such a summary, while the current Summary section could be renamed to Functionality (or something similar). That is if you (and the JOSS editors) agree that this is indeed a useful approach.

I added a short high-level summary in the paper that you can review here whenever you find a little bit of time, and directly add comments / suggestions.

Best

@sebastientourbier
Copy link
Member Author

sebastientourbier commented May 9, 2022

@anilbey I could not add you directly as reviewer but It does not mean you got forgotten ;)

FYI

Dear co-authors/contributors,

Hope you are doing well!

CMP3's review is on going, and while I can take care of most of the points that are very software/docs related, I would need your feedback on this.

In fact in response to the following comment:

The JOSS guidelines state that the paper should have "A summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience". At the moment, the summary section makes out the bulk of the paper, and I consider much of it to be quite detailed and specialist. I don't think this content is a problem though, just that I'm missing a shorter summary for a diverse, non-specialist audience. Perhaps a new paragraph could be included to serve as such a summary, while the current Summary section could be renamed to Functionality (or something similar). That is if you (and the JOSS editors) agree that this is indeed a useful approach.

I added a short high-level summary in the paper that you can review here whenever you find a little bit of time, and directly add comments / suggestions.

Best

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #175 (055634f) into master (af079cf) will not change coverage.
The diff coverage is n/a.

❗ Current head 055634f differs from pull request most recent head 1467af9. Consider uploading reports for the commit 1467af9 to get more accurate results

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files          35       35           
  Lines        7820     7820           
=======================================
  Hits         5682     5682           
  Misses       2138     2138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af079cf...1467af9. Read the comment docs.

Copy link
Collaborator

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks @sebastientourbier !
It's easy to understand for people not having a background in connectomics.

I just made one suggestion and 3 typos.

Co-authored-by: anilbey <tuncel.manil@gmail.com>
@sebastientourbier
Copy link
Member Author

Dear @jsheunis,

Please find in this PR a revised version of the paper which now includes a more high-level summary as well as the renaming of a few sections to integrate your suggestions / comments in #161.

I will merge it when you approve. Please let me know what you think.

Here is a recap of the PR description which more fully details the changes:

PR related to JOSS review: openjournals/joss-reviews#4248

This PR resolves #161.

It addresses issue point 2) by adding in the paper the suggested high-level summary.

It addresses issue points 2 and 3 by renaming the following sections:

* "Summary" -> "Design and functionality overview"

* "Mention" -> "Community impact"

Finally, the sections "Outputs ready to be reused in the BIDS ecosystem" and "A focus on accessibility and versatility" have been swapped to improve the rendering of the compiled PDF.

Generation of the PDF of the most updated draft could done with https://whedon.theoj.org/ as follows: Screen Shot 2022-06-02 at 10 40 24

Thank you very much in advance.
Best regards

Copy link
Contributor

@jsheunis jsheunis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes, the summary contains everything that is important to mention about the package, communicated at a high level for a broader audience.

@sebastientourbier
Copy link
Member Author

Great! I will then take care of the merge :)
I also like these changes that you suggested.
Thank you very much @jsheunis!

@sebastientourbier sebastientourbier merged commit 1bc5683 into master Jun 11, 2022
@sebastientourbier sebastientourbier deleted the rev/paper-highlevel-summary branch June 11, 2022 06:10
@sebastientourbier sebastientourbier mentioned this pull request Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS paper comments
5 participants