-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REV: Add high-level paper summary #175
Conversation
Dear co-authors/contributors, Hope you are doing well! CMP3's review is on going, and while I can take care of most of the points that are very software/docs related, I would need your feedback on this. In fact in response to the following comment:
I added a short high-level summary in the paper that you can review here whenever you find a little bit of time, and directly add comments / suggestions. Best |
@anilbey I could not add you directly as reviewer but It does not mean you got forgotten ;) FYI
|
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=======================================
Coverage 72.65% 72.65%
=======================================
Files 35 35
Lines 7820 7820
=======================================
Hits 5682 5682
Misses 2138 2138 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, thanks @sebastientourbier !
It's easy to understand for people not having a background in connectomics.
I just made one suggestion and 3 typos.
Co-authored-by: anilbey <tuncel.manil@gmail.com>
Co-authored-by: Mikkel Schöttner <48212821+mschoettner@users.noreply.github.com>
Dear @jsheunis, Please find in this PR a revised version of the paper which now includes a more high-level summary as well as the renaming of a few sections to integrate your suggestions / comments in #161. I will merge it when you approve. Please let me know what you think. Here is a recap of the PR description which more fully details the changes:
Thank you very much in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes, the summary contains everything that is important to mention about the package, communicated at a high level for a broader audience.
Great! I will then take care of the merge :) |
PR related to JOSS review: openjournals/joss-reviews#4248
This PR resolves #161.
It addresses issue point 2) by adding in the paper the suggested high-level summary.
It addresses issue points 2 and 3 by renaming the following sections:
Finally, the sections "Outputs ready to be reused in the BIDS ecosystem" and "A focus on accessibility and versatility" have been swapped to improve the rendering of the compiled PDF.
Generation of the PDF of the most updated draft could done with https://whedon.theoj.org/ as follows:
