Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CentOS 6 and CentOS 7 binaries #4775

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Remove CentOS 6 and CentOS 7 binaries #4775

merged 5 commits into from
Jul 5, 2024

Conversation

emasab
Copy link
Collaborator

@emasab emasab commented Jul 1, 2024

keeps using manylinux_2_28 based on AlmaLinux 8 (CentOS 8)

@emasab emasab requested a review from a team as a code owner July 1, 2024 16:38
pranavrth
pranavrth requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few more places where we are still using centos 6/7. Please remove them as well. Following I could find.

https://github.com/confluentinc/librdkafka/blob/dev_remove_centos6_and_centos7/packaging/cp/verify-packages.sh#L20

https://github.com/confluentinc/librdkafka/blob/dev_remove_centos6_and_centos7/packaging/rpm/mock-on-docker.sh#L14

https://github.com/confluentinc/librdkafka/blob/dev_remove_centos6_and_centos7/packaging/rpm/tests/run-test.sh#L19-L28

https://github.com/confluentinc/librdkafka/blob/dev_remove_centos6_and_centos7/packaging/rpm/tests/test-on-docker.sh#L17

pranavrth
pranavrth approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emasab emasab merged commit 847bae1 into master Jul 5, 2024
2 checks passed
@emasab emasab deleted the dev_remove_centos6_and_centos7 branch July 5, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavrth pranavrth pranavrth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emasab @pranavrth