Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual shared and static cmake targets and enable cpack package generation #3042

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

masariello
Copy link

No description provided.

.gitignore Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
packaging/cmake/README.md Show resolved Hide resolved
packaging/cmake/rdkafka.targets Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
src/rdkafka.h Outdated Show resolved Hide resolved
src-cpp/rdkafkacpp.h Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@edenhill
Copy link
Contributor

@raulbocanegra @Oxymoron79 @benesch
Can you please review these CMake changes?

src-cpp/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@masariello
Copy link
Author

masariello commented Sep 14, 2020

@edenhill @raulbocanegra @Oxymoron79 @benesch
I think I covered all the corners about a month ago.
Can this be merged now?
Thanks

@edenhill
Copy link
Contributor

There's similar work being done in #3130, would be good if these two efforts could be combined.

CMakeLists.txt Outdated Show resolved Hide resolved
@edenhill
Copy link
Contributor

Please resolve the conflicts

@cla-assistant
Copy link

cla-assistant bot commented Aug 21, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants