Add rd_kafka_produceva() using a vtype array as an alternative to va-args #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like exactly what I was hoping for. Thanks. It's probably worth getting feedback from maintainers of librdkafka bindings in other languages. The bindings I'm working on are for Haskell, and I can confirm that this strategy works well for Haskell's foreign function interface and FFI-related tooling. |
mhowlett
reviewed
May 26, 2020
| } | ||
|
|
||
| /* Partition the message */ | ||
| err = rd_kafka_msg_partitioner(rkt, rkm, 1); |
There was a problem hiding this comment.
surprised to see this here, probably some unnecessary duplication of stuff, but not a big deal.
There was a problem hiding this comment.
The produceva() code is a direct copy of producev().
mhowlett
reviewed
May 26, 2020
| vus[2].u.header.val = "test value"; | ||
| vus[2].u.header.size = -1; | ||
|
|
||
| error = rd_kafka_produceva(rk, vus, 3); |
There was a problem hiding this comment.
test coverage is a bit light on
mhowlett
approved these changes
May 26, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is problematic to construct va-arg lists for calling C in some high-level languages that wrap librdkafka, erlang in the case of #2895.
This new method allows constructing an array of structs instead.