Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore new findbugs 4.7.0 detectors causing ksql build to fail #9182

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

spena
Copy link
Member

@spena spena commented Jun 7, 2022

Description

What behavior do you want to change, why, how does your patch achieve the changes?
There's an issue with the recent Findbugs 4.7.0 version that introduce new detectors.
spotbugs/spotbugs#2040

The issue seems to fail only on Java 11. This PR excludes the new detectors from findbugs.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@spena spena marked this pull request as ready for review June 7, 2022 16:44
@spena spena requested a review from a team as a code owner June 7, 2022 16:44
@pgaref
Copy link
Member

pgaref commented Jun 7, 2022

We will just need to revert those changes in the next spotbugs release that turns off the false positive alters

@spena spena merged commit 22392f3 into confluentinc:master Jun 8, 2022
@spena spena deleted the fix_findbugs_issue branch June 8, 2022 14:09
@big-andy-coates
Copy link
Contributor

Hey dude, how's it going? Still on ksql I see!

I've fixed this bug. Just waiting for it to be released. :)

@spena
Copy link
Member Author

spena commented Jun 16, 2022

Doing good @big-andy-coates. How about you? Working now in findbugs or what :P? I saw your comments in a findbugs issue and PR which I hoped it would've be ready soon, but I had to patch ksql 'cause it was blocking us. I'll remove these exclusions once there's a findbugs release.

@xli1996
Copy link
Member

xli1996 commented Jul 13, 2022

I updated the common to use 4.7.1 which should include @big-andy-coates 's fix. confluentinc/common#466

@pgaref
Copy link
Member

pgaref commented Jul 14, 2022

Hey @xli1996 -- assuming that spotbug version/plugin is inherited from common we should just bump and revert the exclusions introduced here right?

@xli1996
Copy link
Member

xli1996 commented Jul 14, 2022

yes

@pgaref
Copy link
Member

pgaref commented Jul 15, 2022

yes

Awesome @xli1996 -- would you like to do a followup on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants