Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates for line length style check #645

Merged
merged 1 commit into from
Jan 23, 2018
Merged

updates for line length style check #645

merged 1 commit into from
Jan 23, 2018

Conversation

norwood
Copy link
Contributor

@norwood norwood commented Jan 19, 2018

No description provided.

@norwood norwood requested a review from a team January 19, 2018 18:58
@apurvam
Copy link
Contributor

apurvam commented Jan 19, 2018

Thanks for doing this! Looks like you need to rebase onto master though :(

dguy
dguy approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @norwood, LGTM

@norwood
Copy link
Contributor Author

norwood commented Jan 22, 2018

@apurvam i have rebased this. and though the jenkins integration shows failed, the most recent build is 💚

apurvam
apurvam approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks again!

@apurvam apurvam merged commit 2c67b38 into confluentinc:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguy dguy dguy approved these changes

@apurvam apurvam apurvam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norwood @apurvam @dguy