Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove docker boilerplate now provided by common #618

Merged
merged 2 commits into from
Jan 12, 2018
Merged

remove docker boilerplate now provided by common #618

merged 2 commits into from
Jan 12, 2018

Conversation

aayars
Copy link
Contributor

@aayars aayars commented Jan 12, 2018

No description provided.

@aayars aayars requested a review from a team January 12, 2018 03:22
dguy
dguy approved these changes Jan 12, 2018
View reviewed changes
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aayars, LGTM

@bluemonk3y bluemonk3y self-assigned this Jan 12, 2018
bluemonk3y
bluemonk3y approved these changes Jan 12, 2018
View reviewed changes
Copy link

@bluemonk3y bluemonk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aayars aayars merged commit b9bca57 into confluentinc:master Jan 12, 2018
@aayars aayars deleted the common branch January 12, 2018 17:09
satybald pushed a commit to satybald/ksql that referenced this pull request Jan 17, 2018
@aayars
remove docker boilerplate now provided by common (confluentinc#618)
b11e5b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguy dguy dguy approved these changes

@bluemonk3y bluemonk3y bluemonk3y approved these changes

Assignees

@bluemonk3y bluemonk3y

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aayars @dguy @bluemonk3y