Use Apache commons CSV package for both serializer and deserializer i… #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n delimited format.
satybald
reviewed
Jan 11, 2018
| @@ -82,6 +80,9 @@ public GenericRow deserialize(final String topic, final byte[] bytes) { | |||
|
|
|||
| private Object enforceFieldType(Schema fieldSchema, String delimitedField) { | |||
|
|
|||
| if (delimitedField.length() == 0) { | |||
There was a problem hiding this comment.
one minor suggestion string has isEmpty method, that has the same logic: value.length == 0.
rodesai
reviewed
Jan 12, 2018
| @@ -92,11 +93,7 @@ private Object enforceFieldType(Schema fieldSchema, String delimitedField) { | |||
| case FLOAT64: | |||
| return Double.parseDouble(delimitedField); | |||
| case STRING: | |||
| if (delimitedField.startsWith("'") && delimitedField.endsWith("'")) { | |||
There was a problem hiding this comment.
Why get rid of these checks?
There was a problem hiding this comment.
No need anymore since the read and write is done with the same apache commons package and we currently support default config.
…he-CSV-package-for-delimited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n delimited format.
Previously we only had Apache Commons CSV package in deserializer for delimited format. This PR uses the same package for both serializing and deserializing the delimited format.