Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSQL-473: point quickstart non-docker docs to release tarballs #601

Merged
merged 4 commits into from
Jan 16, 2018

Conversation

rodesai
Copy link
Contributor

@rodesai rodesai commented Jan 5, 2018

Point the quickstart non-docker instructions to the release tarball
on s3. Release tarballs are manually generated and uploaded to the
ksql-releases s3 bucket. This change also updates the instructions
accordingly.

Point the main readme to the release-tagged documentation.

Point the quickstart non-docker instructions to the release tarball
on s3. Release tarballs are manually generated and uploaded to the
ksql-releases s3 bucket. This change also updates the instructions
accordingly.

Point the main readme to the release-tagged documentation.
Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this will go to 0.3 LGTM.

README.md Outdated
@@ -11,8 +11,8 @@ Click here to watch a screencast of the KSQL demo on YouTube.
# Quick Start
If you are ready to see the power of KSQL, try out these:

- [KSQL Quick Start](/docs/quickstart#quick-start): Demonstrates a simple workflow using KSQL to write streaming queries against data in Kafka.
- [Clickstream Analysis Demo](/ksql-clickstream-demo#clickstream-analysis): Shows how to build an application that performs real-time user analytics.
- [KSQL Quick Start][Quick Start]: Demonstrates a simple workflow using KSQL to write streaming queries against data in Kafka.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it an intentional change to move the actual hyperlink to the bottom of the file? (same for two other changed links in here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - I wanted all the links that would need to be updated on release to be grouped together so its less likely one gets missed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodesai i would vote to keep this as-is. especially since the rest of the docs do not follow this convention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to the release-tagged docs from the master README.md, or moving the links down to the bottom of the markdown file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodesai i meant, not moving the links to the bottom. :)

@@ -15,8 +15,6 @@ This part of the quick start will guide you through the steps to setup a Kafka c
- KSQL is in developer preview. Do not run KSQL against a production cluster.
- [Confluent Platform 4.0.0](http://docs.confluent.io/current/installation.html) is installed. This installation includes a Kafka broker, ZooKeeper, Schema Registry, REST Proxy, and Kafka Connect.
- If you installed Confluent Platform via tar or zip, navigate into the installation directory. The paths and commands used throughout this quick start assume that your are in this installation directory.
- [Maven](https://maven.apache.org/install.html)
- [Git](https://git-scm.com/downloads)
Copy link
Contributor

@joel-hamill joel-hamill Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove Git as a prerequisite? isn't this still required down on line 48?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not needed to run KSQL using the release tarball.

@rodesai rodesai merged commit 7ce4942 into master Jan 16, 2018
@rodesai rodesai deleted the ksql_tgz branch March 6, 2018 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants