Skip the '@' character in the beginning of the field name in JSON #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjafarpour
changed the title
dguy
reviewed
Jan 3, 2018
| @@ -132,12 +132,18 @@ private Object enforceFieldType(Schema fieldSchema, JsonNode fieldJsonNode) { | |||
| Iterator<String> fieldNames = jsonNode.fieldNames(); | |||
| while (fieldNames.hasNext()) { | |||
| String fieldName = fieldNames.next(); | |||
| keyMap.put(fieldName.toUpperCase(), fieldName); | |||
| if (fieldName.startsWith("@")) { | |||
There was a problem hiding this comment.
Is it possible that the fieldName could just be @? in which case the next line would fail
There was a problem hiding this comment.
Field name cannot be '@' and if we have '@' as field name we should fail anyway.
There was a problem hiding this comment.
Maybe we should fail with a more meaningful exception? i.e.., not IndexOutOfBoundsException
There was a problem hiding this comment.
Added better error message for field name '@'.
| KsqlJsonDeserializer ksqlJsonDeserializer = new KsqlJsonDeserializer(orderSchema); | ||
|
|
||
| GenericRow genericRow = ksqlJsonDeserializer.deserialize("", jsonBytes); | ||
| Assert.assertTrue(genericRow.getColumns().size() == 6); |
dguy
reviewed
Jan 8, 2018
|
|
||
| GenericRow genericRow = ksqlJsonDeserializer.deserialize("", jsonBytes); | ||
| assertThat("Incorrect columns count.", genericRow.getColumns().size(), equalTo(6)); | ||
| assertThat("Incorrect deserialization", (Long) genericRow.getColumns().get(0) == |
There was a problem hiding this comment.
assertThat(..., equalTo(...))
and elsewhere in the test
Closed
|
Hi, using 5.0.1 this still seems like an issue? Also using Logstash and Elastic and they do use @ for Logstash\Elastic related fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issue reported in #572
Some data sources may create JSON data with
@prefix for field name which is not acceptable as a valid column name in KSQL.In this PR we ignore the
@in the beginning of the field names for JSON formats.Fixes #647 and Fixes #572 and Fixes #264