KSQL-493: Fix producer thread leak #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close QueryMetadata objects created during ddl verification. This in turn closes KafkaStreams, which *should* stop the producer thread. This is currently not happening due to: https://issues.apache.org/jira/browse/KAFKA-6383 There is a PR open to fix that issue: apache/kafka#4343
|
Does this need to get into 0.3, too? |
|
It’s not a blocker for 0.3 IMO
… On Dec 20, 2017, at 09:59, Michael G. Noll ***@***.***> wrote:
Does this need to get into 0.3, too?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
apurvam
approved these changes
Dec 20, 2017
|
@miguno this won't break anything from a correctness POV. Its more of a resource utilization issue for somebody trying to run a long-running server. Plus this PR on its own doesn't actually help much. We need to get the KAFKA PR merged/released as well. |
|
@rodesai : Ah, thanks for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close QueryMetadata objects created during ddl verification.
This in turn closes KafkaStreams, which should stop the
producer thread. This is currently not happening due to:
https://issues.apache.org/jira/browse/KAFKA-6383
There is a PR open to fix that issue:
apache/kafka#4343