Add ability to specify the schema registry url to the CLI in local mode. #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Will enable us to use avro in the quickstart
apurvam
changed the title
|
retest this please |
|
The same CLITest failed twice. It is getting less stable now apparently :( |
hjafarpour
approved these changes
Dec 19, 2017
| + "schema registry which the KSQL instance can connect to." | ||
| ) | ||
| String schemaRegistryUrl; | ||
|
|
There was a problem hiding this comment.
Also mention that setting the schema registry property here will overwrite the one in the properties file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, we can use schema registry in the quickstart docker images. We would need to update the https://github.com/confluentinc/ksql/blob/master/docs/quickstart/quickstart-docker.md so that we update the
execcommand to: