Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor style issues in the docs. #543

Merged
merged 4 commits into from
Dec 19, 2017

Conversation

hjafarpour
Copy link
Contributor

Updated the docs based on the new query id format.

@@ -53,7 +53,7 @@ services:

# Runs the Kafka KSQL data generator for topic called "pageviews"
ksql-datagen-pageviews:
image: "confluentinc/ksql-examples:0.2"
image: "confluentinc/ksql-examples:0.3-rc1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably don't want to push these changes just yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, removed them.

Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@apurvam
Copy link
Contributor

apurvam commented Dec 18, 2017

retest this please

1 similar comment
@hjafarpour
Copy link
Contributor Author

retest this please

@hjafarpour hjafarpour merged commit 6f62658 into confluentinc:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants