Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of actual results to CLITest output when it fails #494

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

apurvam
Copy link
Contributor

@apurvam apurvam commented Nov 30, 2017

The CliTest still fails. This patch adds logging so that we know the actual results we got when it fails. It could be that no results are ever returned, or it could be that there is another error and error strings are returned. This patch will learn the cause of the failures.

Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apurvam apurvam merged commit bd9bd58 into confluentinc:4.0.x Dec 1, 2017
@apurvam apurvam deleted the add-logging-to-cli-test branch December 1, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants