Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide user name and password command line flags #485

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

apurvam
Copy link
Contributor

@apurvam apurvam commented Nov 28, 2017

This patch hides the --username and --password cli flags since the server side auth components are not generally available. All the functionality is still available, but these flags will not be listed in the help commands of the CLI.

…e server side auth components are not yet generally available.
@apurvam apurvam changed the base branch from 4.0.x to master November 28, 2017 21:27
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apurvam, LGTM

Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apurvam apurvam merged commit fb294b6 into confluentinc:master Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants