Add doc for fail.on.deserialization.error #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/examples.md
Outdated
| @@ -304,6 +304,11 @@ Common configuration properties that you might want to change from their default | |||
| - [cache.max.bytes.buffering](https://kafka.apache.org/documentation/#streamsconfigs): | |||
| The default value in KSQL is `10000000` (~ 10 MB); | |||
|
|
|||
| - fail.on.deserialization.error: | |||
| When set to true (the default), any errors that occur when deserializing a record will result in the the error being logged and the record being dropped. | |||
| If you wish to halt processing on deserialization errors you should set this to false. | |||
There was a problem hiding this comment.
seems a bit counter-intuitive ? i.e. set the "fail on error" flag to false to NOT halt ("fail") on error ? i predict significant user confusion for this...
There was a problem hiding this comment.
doh! thanks for pointing out. It is the other way around!
There was a problem hiding this comment.
lol - makes much more sense now!
|
@dguy - think you could also add a mention of it on the bottom of this page (where it talks about config)? https://github.com/confluentinc/ksql/blob/0.1.x/docs/syntax-reference.md#syntax-reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.