fix more findbugs warnings

ksql-cli/src/main/java/io/confluent/ksql/util/CliUtils.java

@@ -23,9 +23,11 @@
 import org.codehaus.jackson.JsonParseException;
 
 import java.io.BufferedReader;
-import java.io.FileReader;
+import java.io.FileInputStream;
 import java.io.IOException;
+import java.io.InputStreamReader;
 import java.net.ConnectException;
+import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
@@ -82,9 +84,8 @@ public String getAvroSchema(final String schemaFilePath) {
 
   public String readQueryFile(final String queryFilePath) throws IOException {
     StringBuilder sb = new StringBuilder();
-    BufferedReader br = null;
-    try {
-      br = new BufferedReader(new FileReader(queryFilePath));
+    try (final BufferedReader br = new BufferedReader(new InputStreamReader(
+        new FileInputStream(queryFilePath), StandardCharsets.UTF_8))) {
       String line = br.readLine();
       while (line != null) {
         sb.append(line);
@@ -93,10 +94,6 @@ public String readQueryFile(final String queryFilePath) throws IOException {
       }
     } catch (IOException e) {
       throw new KsqlException("Could not read the query file. Details: " + e.getMessage(), e);
-    } finally {
-      if (br != null) {
-        br.close();
-      }
     }
     return sb.toString();
   }

ksql-engine/src/main/java/io/confluent/ksql/util/ExpressionMetadata.java

@@ -40,11 +40,15 @@ public IExpressionEvaluator getExpressionEvaluator() {
   }
 
   public int[] getIndexes() {
-    return indexes;
+    final int [] result = new int[indexes.length];
+    System.arraycopy(indexes, 0, result, 0, indexes.length);
+    return result;
   }
 
   public Kudf[] getUdfs() {
-    return udfs;
+    final Kudf[] result = new Kudf[udfs.length];
+    System.arraycopy(udfs, 0, result, 0, udfs.length);
+    return result;
   }
 
   public Schema getExpressionType() {

ksql-examples/src/main/java/io/confluent/ksql/datagen/DataGenProducer.java

@@ -147,8 +147,7 @@ private int mapSessionValueToSibling(String sessionisationValue, Schema.Field fi
       LinkedHashMap properties = (LinkedHashMap) field.schema().getObjectProps().get("arg.properties");
       Integer max = (Integer) ((LinkedHashMap) properties.get("range")).get("max");
 
-      int hash = Math.abs(sessionisationValue.hashCode());
-      int vvalue = hash % max.intValue();
+      int vvalue = Math.abs(sessionisationValue.hashCode() % max);
 
       int foundValue = -1;
       // used - search for another

ksql-metastore/src/main/java/io/confluent/ksql/metastore/MetaStoreImpl.java

@@ -22,7 +22,7 @@
 import java.util.Map;
 import java.util.Set;
 
-public class MetaStoreImpl implements MetaStore {
+public class MetaStoreImpl implements MetaStore, Cloneable {
 
   private final Map<String, KsqlTopic> topicMap;
   private final Map<String, StructuredDataSource> dataSourceMap;

ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/computation/CommandStore.java

@@ -46,7 +46,7 @@ public class CommandStore implements Closeable {
 
     private static final Logger log = LoggerFactory.getLogger(CommandStore.class);
 
-    public static long POLLING_TIMEOUT_FOR_COMMAND_TOPIC = 5000;
+    private static final long POLLING_TIMEOUT_FOR_COMMAND_TOPIC = 5000;
 
     private final String commandTopic;
     private final Consumer<CommandId, Command> commandConsumer;

ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/resources/streaming/QueryStreamWriter.java

@@ -113,7 +113,7 @@ public void write(OutputStream out) throws IOException {
 
   void write(OutputStream output, GenericRow row) throws IOException {
     objectMapper.writeValue(output, new StreamedRow(row));
-    output.write("\n".getBytes());
+    output.write("\n".getBytes(StandardCharsets.UTF_8));
     output.flush();
   }