Put window aggregate logic into the various KsqlWindowExpression classes #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
retest this please |
blueedgenick
added a commit
to blueedgenick/ksql
that referenced
this pull request
Oct 18, 2017
* KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image KSQL screencast image * remove here hyperlink * Added LIKE examples to syntax guide and examples. * Fixed typo. * Minor doc changes. * Improvements to syntax guide * Restructure TOC * Fixed misspelled words * Fixed a minor error in the syntax guide. * Clarify PARTITION BY in CSAS * remove build-tools copy, use pluginRepository in pom (confluentinc#286) * Add section Use Cases and Examples * Fix typo * Add missing word to roadmap * Clarify FAQ * Remove trailing whitespace * Add Configure KSQL to Syntax Guide, fix/clariy config examples * Emit succinct error for missing query file * Add upstream project so build are triggered automatically * Clarify client-server mode * Clarifications * Add `$` to CLI commands * Clarifications * Clarifications * Clarifications * Fix typo * Remove bullet formatting * fix checkstyle errors * Document how to configure the Kafka bootstrap servers * Update non-docker-clickstream.md * Clarify KSQL works with AK and CP * small-code-quality-improvements Added code quality improvements. * small-code-quality-improvements Added code quality improvements. * added persistent information for streams and table * fixing commandstore hanging * reduced poll on priorCommands processing * removed header p html * added comment on poll instead of subscribe * Clarify how streams and tables are stored in topics * Including the streams config properties in the session with CTAS and CSAS statements in the service execution mode. * refactoring parser, core and common * extracted serde module * Refactored the package for GenericRow. * Fixed the drop table issue. * extracted pipeline Please enter the commit message for your changes. Lines starting * rename ksql-core to ksql-engine * Add to Examples: WHERE clause and content-based routing (confluentinc#333) * First step in better testing tools. Added an integration test tool to create topics and pump data into the topic and pull data from topics. * No need to set the streams application.id for the rest server. * First pass on refactoring KSQL confing. * extracting new integration test using KSQLContext Please enter the commit message for your changes. Lines starting * Refined admin client config. * remove dead code. make field and method access more restricted * bump common dependency to 3.3.1-SNAPSHOT * using 0.11.0.1 of client to use fixed AdminClient * kafka version setting to 11.0.1 * remove unused imports * remove dead code. change access modifiers. general tidy up. * Minor change to use the same Application Id for embedded mode. * Some changes based on the new KSQLConfig. * replace window-unit with TimeUnit (confluentinc#346) * skip bad data in json and delimited deserializer (confluentinc#347) * Clean up the poms after the refactor that created new packages. * More pom clean up. * Reverting adminclient singleton temporarily. * Bump to common 4.0.0-SNAPSHOT * Bump to common 4.1.0-SNAPSHOT * update slack channel for build notifications * fix artifact version in compose file * After bumping the dependency to 4.0.0 we encountered some issues that this commit fixes them. * Better clean up for queries. Internal topics will be deletted after query termination. * Added singleton AdminClient back. * extract methods, remove duplication, etc from PhysicalPlanBuilder (confluentinc#356) * Use streams 1.0 api methods (confluentinc#365) * new PR with migrated tests * tidying stuff up * trigger build * remove more crud * Fixed the pom version. * Pom version fix. * Refactored Function registry. * adding windowing integration tests, updated streams int test util to latest version * trigger * moving packages * Applied review feedback. * Remove SourceNode as it is redundant (confluentinc#368) * remove SourceNode as it is redundant * Add test for KsqlTable datasource in LogicalPlanner * adding stream-table join * exposing time controls when publishing test data * exposing time controls for int tests * removed old comments * trigger build * remove jackson dependency in ksql-rest-app. (confluentinc#369) * remove jackson dependency in ksql-rest-app. remove @JsonUnwrapped from places where it doesn't work * add missng pom update * move the createsink method out of SchemaKStream (confluentinc#376) * make join test more reliable (confluentinc#381) * rework threading on QueryStreamWriter * import * import * import * Use streams deserializtion exception handler (confluentinc#385) * extract SelectValueMapper from SchemaKXxxx (confluentinc#379) * minor tidyups * Put window aggregate logic into the various KsqlWindowExpression classes (confluentinc#377) * make the window expressions do some work * add test scope to easymock dependency * Minor modification in KSQLContext.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.