Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring parser, core and common #325

Merged
merged 2 commits into from
Sep 29, 2017
Merged

refactoring parser, core and common #325

merged 2 commits into from
Sep 29, 2017

Conversation

bluemonk3y
Copy link

pull apart metastore, parser and started common

@bluemonk3y
Copy link
Author

part of #326

@hjafarpour
Copy link
Contributor

hjafarpour commented Sep 29, 2017 •
edited
Loading

@bluemonk3y Let's create a new module for SERDE and move it from metastore to the new one.
Also let's change the package name for GenericRow in the common module from 'physical'. Maybe we can just move it a level up or rename the package name to something like data/row.

@hjafarpour hjafarpour merged commit 35e6a40 into confluentinc:0.1.x Sep 29, 2017
@bluemonk3y bluemonk3y deleted the 0.1.x-CODE-restructure branch September 29, 2017 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjafarpour hjafarpour hjafarpour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluemonk3y @hjafarpour