add-some-unit-tests

[TheRealHaui]

Added some unit tests.

[ConfluentJenkins]

Can one of the admins verify this patch?

[ghost]

It looks like @TheRealHaui hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

[TheRealHaui]

[clabot:check]

[ghost]

@confluentinc It looks like @TheRealHaui just signed our Contributor License Agreement. 👍

Always at your service,

clabot

[hjafarpour]

@TheRealHaui Thanks for your contribution. You need to sign Contributor License Agreement before merging your PRs.

[TheRealHaui]

[clabot:check]

[ghost]

@confluentinc It looks like @TheRealHaui just signed our Contributor License Agreement. 👍

Always at your service,

clabot

[TheRealHaui]

@hjafarpour
Your contribution license was signed by me.

[hjafarpour]

@TheRealHaui We made some refactoring in the code. Would you please update your code accordingly before we can merge it.
Thanks.

[miguno]

@hjafarpour : If @TheRealHaui doesn't have the time to follow-up, I'd suggest that we help to update the code in this PR to match latest master.

[TheRealHaui]

I am going to update the code in the next few days.
Haven't had time yet.

[TheRealHaui]

Thanks for the kind proposal.

[miguno]

@TheRealHaui:

I am going to update the code in the next few days. Haven't had time yet.

Great, that's even better. :-)

Thank you!

[TheRealHaui]

@hjafarpour, @miguno
Here we go.

[TheRealHaui]

Updated branch to current code.
Tests work locally without problems.
Can't see why codacy reports problems.
Probably a problem of codacy.

[bluemonk3y]

@TheRealHaui - you can ignore codacy...

[bluemonk3y]

@TheRealHaui - sorry - but we are working on the 4.0.x branch. Its to do with some upcoming work. Would you be able to switch it over?

[TheRealHaui]

Something went completely wrong during switching to 4.0.x branch ...
Going to correct issues in the next few days.

[TheRealHaui]

@hjafarpour
Now everything should work.

[dguy]

retest this please

[TheRealHaui]

@dguy
Thank you for your answer.

Unfortunately I can't build anything using the 4.0.x branch!
I guess it is necessary to change something in the .m2/settings.xml file because utilizing "mvn clean install -U -X" gives me this exeception: Caused by: org.apache.maven.project.DependencyResolutionException: Could not resolve dependencies for project io.confluent.ksql:ksql-parent:pom:4.0.0-SNAPSHOT: Could not find artifact io.confluent:common-utils🫙4.0.0-SNAPSHOT in confluent (http://packages.confluent.io/maven/)

[TheRealHaui]

Any advice?

[dguy]

@TheRealHaui you could try adding:

<mirror>
     <id>confluent-nexus-central</id>
     <mirrorOf>default,central,confluent</mirrorOf>
     <url>https://nexus.confluent.io/repository/maven-public</url>
   </mirror>

[TheRealHaui]

@dguy
Thanks for your advice.
Tried it but it doesn't help.
However, asked the question regarding building in the Slack chat: https://confluentcommunity.slack.com/archives/C6UJNMY67/p1509368674000098

Thanks for merging.