Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't replay all previous events found on the command topic #454

Closed
dguy opened this issue Nov 10, 2017 · 0 comments
Closed

Don't replay all previous events found on the command topic #454

dguy opened this issue Nov 10, 2017 · 0 comments
Assignees
@dguy
Labels
bug

Comments

@dguy
Copy link
Contributor

dguy commented Nov 10, 2017 •
edited
Loading

When starting up we currently replay all events on the command topic. Which means a couple of we will likely end up running queries, create statements etc, that have subsequently been terminated or dropped.

We should not run queries for tables that have been dropped. To do this we can do some compaction in the getPreviousCommand call and change the queryId such that it is derived from the statement, i.e., so we don't rely on a counter and it will be consistent across all engines.
@dguy dguy self-assigned this Nov 10, 2017
@apurvam apurvam added the bug label Nov 10, 2017
@dguy dguy mentioned this issue Nov 13, 2017
Closed
@dguy dguy changed the title Command topic should be compacted Don't replay all previous events found on the command topic Nov 23, 2017
@dguy dguy mentioned this issue Nov 23, 2017
Merged
dguy added a commit that referenced this issue Dec 1, 2017
@dguy
Don't replay all previous events found on the command topic #454 (#480)
d996bdb 
* remove terminate command.
terminate persistent queries when a stream or table is dropped.
"compact" previous commands during restart so we don't replay dropped queries etc.
change queryId so that it is derived from the statement.

* add missing classes

* add back terminate

* address comments

* remove main method
@dguy dguy closed this as completed Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dguy dguy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dguy @apurvam