Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE fix: Update parquet-format version to remove vulnerabilities #259

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

sidd1809
Copy link
Contributor

@sidd1809 sidd1809 commented Aug 2, 2022

Problem

CCMSG-2014: Vulnerable dependency "parquet:parquet-format-structures" for kafka-connect-storage-cloud:master-latest

Solution

Update version of parquet-format to 1.11.2

Does this solution apply anywhere else?
  • yes
  • no

Test Strategy

Tested with unit-tests and integration-test in kafka-connect-storage-cloud

Testing done:

N/A

  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

Release as patch versions

@sidd1809 sidd1809 requested a review from a team as a code owner August 2, 2022 19:41
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sidd1809 sidd1809 changed the title CVE fix parquet CVE fix: Update parquet-format version to remove vulnerabilities Aug 2, 2022
pom.xml Outdated
@@ -77,7 +77,7 @@
<hive.version>1.2.2</hive.version>
<joda.version>2.9.6</joda.version>
<licenses.version>5.4.10-SNAPSHOT</licenses.version>
<parquet.version>1.11.1</parquet.version>
<parquet.version>1.11.2</parquet.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not to the latest version 1.12.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I basically used the earliest version which doesn't have the mentioned CVE.

I can bump up to 1.12.3, given looking at changelog for 1.12.0, it seems there is nothing mentioned as backward in-compatible

Copy link
Member

@arihant-confluent arihant-confluent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can run integration/ manual test if not done already

@sidd1809 sidd1809 merged commit 4909c78 into 5.4.x Aug 3, 2022
@sidd1809 sidd1809 deleted the cve-fix-parquet branch August 3, 2022 08:00
sidd1809 added a commit that referenced this pull request Aug 3, 2022
* CVE fix: Update parquet-format version to remove vulnerabilities  (#259)

Co-authored-by: Siddhartha Agarwal <pulsid.agarwal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants