Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing schema registry URL in rest, c3 and ksql (see issue 1425) #1426

Open
wants to merge 432 commits into
base: 7.4.0-post
Choose a base branch
from

Conversation

Schm1tz1
Copy link
Member

@Schm1tz1 Schm1tz1 commented Jun 20, 2023

Description

When deploying self-managed components, schema.registry.url is missing for rest, ksql and c3 properties even if ccloud_schema_registry_url is congihured and ccloud_schema_registry_enabled: true while for connect it does work.

This is a fix for this issue.

Fixes # 1425

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Example deployment in hybrid CCloud setup with a customer.

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

rrbadiani and others added 30 commits December 27, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants