Fixed: ListGroup throws exception if group doesn't exist #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mhowlett
changed the title
rayokota
added a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #34 as suggested by @bschmidtbauer
Note:
GroupInfois now a class, not a struct which allowsListGroupto returnnullif the group doesn't exist.TODO: as part of this PR let's re-consider whether any of our other structs would be better off as classes (almost certainly yes). https://msdn.microsoft.com/en-us/library/ms229017.aspx
Also re-think organization of files (struct folder is getting less appropriate).
Also: are
QueryGroupandQueryGroupsbetter names for methodsListGroupandListGroups? (isListGroupa bit wrong?). The 'Query' names would be consistent withQueryWatermarkOffsets. A problem with this idea is the corresponding function in librdkafka is list_groups. So maybeQueryGroupandListGroups? don't like the inconsistency. I guess the current names are the best given all the constraints.