KIP 396 ListOffsets #2086
Merged
KIP 396 ListOffsets #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anchitj
requested changes
Oct 3, 2023
anchitj
requested changes
Oct 4, 2023
anchitj
requested changes
Oct 9, 2023
anchitj
reviewed
Oct 9, 2023
anchitj
reviewed
Oct 10, 2023
mahajanadhitya
force-pushed
the
feature/AdminClient-ListOffsets
branch
from
1cb8861
to
6592b2d
Compare
anchitj
reviewed
Oct 13, 2023
anchitj
reviewed
Oct 13, 2023
mahajanadhitya
force-pushed
the
feature/AdminClient-ListOffsets
branch
from
6592b2d
to
7c049ac
Compare
emasab
force-pushed
the
feature/AdminClient-ListOffsets
branch
from
ee6da94
to
dcf4499
Compare
anchitj
reviewed
Oct 19, 2023
emasab
force-pushed
the
feature/AdminClient-ListOffsets
branch
from
23c898a
to
b5ba287
Compare
anchitj
reviewed
Oct 19, 2023
Comment on lines
+72
to
+75
| internal TimestampSpec(long timestamp) | ||
| { | ||
| Timestamp = timestamp; | ||
| } |
There was a problem hiding this comment.
We can probably keep private set; accessor replacing this.
|
|
||
| namespace Confluent.Kafka.Admin | ||
| { | ||
| /// <summary> | ||
| /// Represents the result of a list offsets operation. | ||
| /// Represents an error that occurred during a ListOffsets request. |
There was a problem hiding this comment.
The result of ListOffsets request (including error status).
| } | ||
| }; | ||
|
|
||
| var listOffsetsResult = await adminClient.ListOffsetsAsync(topicPartitionOffsetSpecs,options); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.