-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KIP-554] User SCRAM credentials API #2070
Conversation
…tegrationTests for now from semaphore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration tests are failing. Can we fix that as well please?
test/Confluent.SchemaRegistry.IntegrationTests/Tests/ProtobufWithReferences.cs
Outdated
Show resolved
Hide resolved
Tried running the tests locally but they seem to be getting stuck indefinitely. Can you please check? |
src/Confluent.Kafka/Admin/DescribeUserScramCredentialsOptions.cs
Outdated
Show resolved
Hide resolved
test/Confluent.Kafka.IntegrationTests/Tests/AdminClient_UserScram.cs
Outdated
Show resolved
Hide resolved
test/Confluent.Kafka.IntegrationTests/Tests/AdminClient_AlterConfigs.cs
Outdated
Show resolved
Hide resolved
test/Confluent.Kafka.IntegrationTests/Tests/AdminClient_UserScram.cs
Outdated
Show resolved
Hide resolved
test/Confluent.Kafka.IntegrationTests/Tests/AdminClient_UserScram.cs
Outdated
Show resolved
Hide resolved
src/Confluent.Kafka/Admin/DescribeUserScramCredentialsResult.cs
Outdated
Show resolved
Hide resolved
test/Confluent.Kafka.IntegrationTests/Tests/AdminClient_UserScram.cs
Outdated
Show resolved
Hide resolved
test/Confluent.Kafka.IntegrationTests/Tests/AdminClient_UserScram.cs
Outdated
Show resolved
Hide resolved
Also add a CHANGELOG entry |
Add exceptions Remove AlterUserScramCredentialsResult Add DescribeUserScramCredentialsReport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified all the integration tests are passing against feature/userscram-AdminClient
librdkafka.
test/Confluent.Kafka.IntegrationTests/Tests/AdminClient_UserScram.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just need to add changelog before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests. LGTM. Probably needs a rebase with the master as it's showing conflict in the CHANGELOG.
No description provided.