Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIP-554] User SCRAM credentials API #2070

Merged
merged 39 commits into from
Jul 12, 2023
Merged

Conversation

mahajanadhitya
Copy link
Contributor

No description provided.

Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests are failing. Can we fix that as well please?

.semaphore/semaphore.yml Outdated Show resolved Hide resolved
src/Confluent.Kafka/IAdminClient.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/Impl/SafeKafkaHandle.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/Impl/SafeKafkaHandle.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/AdminClient.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/AdminClient.cs Outdated Show resolved Hide resolved
@anchitj
Copy link
Member

anchitj commented Jul 6, 2023

Tried running the tests locally but they seem to be getting stuck indefinitely. Can you please check?

.semaphore/semaphore.yml Outdated Show resolved Hide resolved
src/Confluent.Kafka/Admin/UserScramCredentialDeletion.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/AdminClient.cs Outdated Show resolved Hide resolved
examples/AdminClient/Program.cs Outdated Show resolved Hide resolved
examples/AdminClient/Program.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/AdminClient.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/AdminClient.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/AdminClient.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/AdminClient.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/Impl/SafeKafkaHandle.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/Impl/SafeKafkaHandle.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/Impl/SafeKafkaHandle.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/Impl/SafeKafkaHandle.cs Outdated Show resolved Hide resolved
@anchitj
Copy link
Member

anchitj commented Jul 7, 2023

Also add a CHANGELOG entry

Add exceptions
Remove AlterUserScramCredentialsResult
Add DescribeUserScramCredentialsReport
Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified all the integration tests are passing against feature/userscram-AdminClient librdkafka.

src/Confluent.Kafka/Confluent.Kafka.csproj Outdated Show resolved Hide resolved
src/Confluent.Kafka/AdminClient.cs Show resolved Hide resolved
@emasab emasab changed the title Feature/admin client scramapi [KIP-554] User SCRAM credentials API Jul 10, 2023
Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to add changelog before merging.

Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests. LGTM. Probably needs a rebase with the master as it's showing conflict in the CHANGELOG.

@anchitj anchitj merged commit 39f4206 into master Jul 12, 2023
@anchitj anchitj deleted the feature/AdminClient-SCRAMAPI branch July 12, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants