Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-906 Cluster Registry CRUD #513

Merged
merged 8 commits into from
Jun 26, 2020
Merged

SEC-906 Cluster Registry CRUD #513

merged 8 commits into from
Jun 26, 2020

Conversation

tadsul
Copy link
Contributor

@tadsul tadsul commented Jun 9, 2020

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

    • yes: ok
    • no: DO NOT MERGE until the required functionalites are live in prod
  2. Did you add/update any commands that accept secrets as args/flags?

What

References

Test&Review

@tadsul tadsul requested a review from a team as a code owner June 9, 2020 18:43
@tadsul tadsul requested a review from DABH June 9, 2020 18:47
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, let me know what you think and then I think I can +1. Thanks!

internal/cmd/connector/command_cluster_onprem.go Outdated Show resolved Hide resolved
internal/pkg/errors/cobra.go Outdated Show resolved Hide resolved
internal/pkg/cluster/cluster.go Show resolved Hide resolved
internal/cmd/command.go Outdated Show resolved Hide resolved
internal/cmd/kafka/command.go Outdated Show resolved Hide resolved
@DABH
Copy link
Contributor

DABH commented Jun 11, 2020

(Also, @tadsul you should probably merge master into this branch, and then make sure CI passes)

Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 once master is properly merged into this branch and once CI passes

@DABH
Copy link
Contributor

DABH commented Jun 12, 2020

(Also please delete that unused file)

- Added Cluster Registry register, unregister command
- Modified Cluster Registry List Command to align with ccloud cluster list command
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8b09744). Click here to learn what that means.
The diff coverage is 82.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #513   +/-   ##
=========================================
  Coverage          ?   51.91%           
=========================================
  Files             ?      170           
  Lines             ?    13935           
  Branches          ?        0           
=========================================
  Hits              ?     7234           
  Misses            ?     5850           
  Partials          ?      851           
Impacted Files Coverage Δ
cmd/lint/main.go 0.00% <ø> (ø)
internal/cmd/kafka/command_cluster_cloud.go 81.60% <ø> (ø)
internal/pkg/errors/cobra.go 72.41% <ø> (ø)
internal/cmd/cluster/command_registry.go 70.00% <70.00%> (ø)
internal/pkg/cluster/cluster.go 80.55% <80.55%> (ø)
internal/cmd/cluster/command_list.go 82.60% <83.33%> (ø)
internal/cmd/connect/command_cluster_onprem.go 88.23% <88.23%> (ø)
internal/cmd/kafka/command_cluster_onprem.go 88.23% <88.23%> (ø)
internal/cmd/ksql/command_cluster_onprem.go 88.23% <88.23%> (ø)
...rnal/cmd/schema-registry/command_cluster_onprem.go 88.23% <88.23%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b09744...0602803. Read the comment docs.

Copy link

@csreesan csreesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a nit comment

internal/cmd/kafka/command_test.go Outdated Show resolved Hide resolved
internal/cmd/ksql/command_test.go Show resolved Hide resolved
@tadsul tadsul merged commit dfcef2d into master Jun 26, 2020
@tadsul tadsul deleted the clusterRegistryLatest branch June 26, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants