-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEC-906 Cluster Registry CRUD #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, let me know what you think and then I think I can +1. Thanks!
(Also, @tadsul you should probably merge master into this branch, and then make sure CI passes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 once master is properly merged into this branch and once CI passes
(Also please delete that unused file) |
98505cf
to
e49142a
Compare
- Added Cluster Registry register, unregister command - Modified Cluster Registry List Command to align with ccloud cluster list command
e49142a
to
fc1b579
Compare
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
=========================================
Coverage ? 51.91%
=========================================
Files ? 170
Lines ? 13935
Branches ? 0
=========================================
Hits ? 7234
Misses ? 5850
Partials ? 851
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a nit comment
68d1deb
to
0602803
Compare
https://confluentinc.atlassian.net/wiki/spaces/PM/pages/1118899222/Cluster+Registry+CLI+UX
https://confluentinc.atlassian.net/wiki/spaces/PM/pages/1273331929/2020-05-18+CR+CLI+Cluster+List+Plotting
Checklist
[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
Did you add/update any commands that accept secrets as args/flags?
secretCommandFlags
and/orsecretCommandArgs
in internal/pkg/analytics/analytics.goWhat
References
Test&Review