is_contract revisited
#368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
force-pushed
the
213-is_contract-revisited
branch
from
fae662f
to
59c45dc
Compare
maurolacy
force-pushed
the
213-is_contract-revisited
branch
from
59c45dc
to
bbbd3ce
Compare
maurolacy
force-pushed
the
213-is_contract-revisited
branch
from
bbbd3ce
to
06bd7d0
Compare
ueco-jb
approved these changes
Dec 1, 2021
Comment on lines
+1211
to
+1215
| SystemResult::Ok(ContractResult::Err(contract_err)) | ||
| if contract_err.contains("not found") => | ||
| { | ||
| Ok(false) | ||
| } |
There was a problem hiding this comment.
We need to normalise this on wasmd side.
See CosmWasm/wasmd#687
But this is a great work-around for the current state
ethanfrey
approved these changes
Dec 1, 2021
Comment on lines
+1211
to
+1215
| SystemResult::Ok(ContractResult::Err(contract_err)) | ||
| if contract_err.contains("not found") => | ||
| { | ||
| Ok(false) | ||
| } |
There was a problem hiding this comment.
We need to normalise this on wasmd side.
See CosmWasm/wasmd#687
But this is a great work-around for the current state
This was referenced Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #367.