-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_contract
revisited
#368
Conversation
fae662f
to
59c45dc
Compare
59c45dc
to
bbbd3ce
Compare
bbbd3ce
to
06bd7d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SystemResult::Ok(ContractResult::Err(contract_err)) | ||
if contract_err.contains("not found") => | ||
{ | ||
Ok(false) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to normalise this on wasmd side.
See CosmWasm/wasmd#687
But this is a great work-around for the current state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Notes to make a few follow-up issues for the remaining FIXMEs
SystemResult::Ok(ContractResult::Err(contract_err)) | ||
if contract_err.contains("not found") => | ||
{ | ||
Ok(false) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to normalise this on wasmd side.
See CosmWasm/wasmd#687
But this is a great work-around for the current state
Closes #367.