Fix compilation warnings #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails because of the following issue related to the toolchain: I think #755 solves the problem |
|
@zlukwins , please fix rest CI failure. |
The following warnings are being fixed:
warning: unused import: `linked_list_allocator::LockedHeap`
--> deps/td-shim/td-payload/src/mm/heap.rs:6:5
|
6 | use linked_list_allocator::LockedHeap;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: unused import: `td_benchmark::Alloc`
--> deps/td-shim/td-payload/src/mm/heap.rs:8:5
|
8 | use td_benchmark::Alloc;
| ^^^^^^^^^^^^^^^^^^^
warning: unnecessary `unsafe` block
--> deps/td-shim/td-payload/src/mm/heap.rs:30:5
|
30 | unsafe {
| ^^^^^^ unnecessary `unsafe` block
|
= note: `#[warn(unused_unsafe)]` on by default
Signed-off-by: Zbigniew Lukwinski <zbigniew.lukwinski@intel.com>
zlukwins
force-pushed
the
fix-compilation-warnings
branch
from
9d31933 to
a6aac76
Compare
@jyao1 , done |
jyao1
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following warnings are being fixed:
warning: unused import:
linked_list_allocator::LockedHeap--> deps/td-shim/td-payload/src/mm/heap.rs:6:5
|
6 | use linked_list_allocator::LockedHeap;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note:
#[warn(unused_imports)]on by defaultwarning: unused import:
td_benchmark::Alloc--> deps/td-shim/td-payload/src/mm/heap.rs:8:5
|
8 | use td_benchmark::Alloc;
| ^^^^^^^^^^^^^^^^^^^
warning: unnecessary
unsafeblock--> deps/td-shim/td-payload/src/mm/heap.rs:30:5
|
30 | unsafe {
| ^^^^^^ unnecessary
unsafeblock|
= note:
#[warn(unused_unsafe)]on by default