Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to upgrade the toolchain to 1.59 release to accept "strip" option in release profile #269

Closed
longlongyang opened this issue May 16, 2022 · 4 comments · Fixed by #270
Closed

Need to upgrade the toolchain to 1.59 release to accept "strip" option in release profile #269

longlongyang opened this issue May 16, 2022 · 4 comments · Fixed by #270
Assignees
@liuw1

Comments

@longlongyang
Copy link
Contributor

Background: #256 (comment)
The current stable toolchain version 1.58 release doesn't support the "strip" option in release profile, which breaks the reproducible build.
We need to upgrade the version of toolchain to 1.59 release, since the profile strip option has been stabilized in the 1.59 release. More detail please find: https://doc.rust-lang.org/cargo/reference/unstable.html#profile-strip-option
@jyao1
Copy link
Member

jyao1 commented May 16, 2022

@liuw1, can you take a look to upgrade the version in CI ?

It causes the CI failure - #268

@liuw1
Copy link
Contributor

liuw1 commented May 16, 2022

Sure

@jyao1 jyao1 assigned jyao1 and liuw1 and unassigned jyao1 May 16, 2022
liuw1 added a commit to liuw1/td-shim that referenced this issue May 16, 2022
@liuw1
Update stable rust toolchain to 1.60.0
08c826d 
Fix confidential-containers#269

Signed-off-by: Wei Liu <wei3.liu@intel.com>
@liuw1 liuw1 mentioned this issue May 16, 2022
Merged
@liuw1
Copy link
Contributor

liuw1 commented May 16, 2022

I have checked all CI related test tasks except TDX integration test task with #268, all tasks passed with the latest stable toolchain.

@longlongyang
Copy link
Contributor Author

I have checked all CI related test tasks except TDX integration test task with #268, all tasks passed with the latest stable toolchain.

Thanks, I am working on to solve that TDX integration test task failure

jyao1 pushed a commit that referenced this issue May 16, 2022
@liuw1 @jyao1
Update stable rust toolchain to 1.60.0
552e40d 
Fix #269

Signed-off-by: Wei Liu <wei3.liu@intel.com>
@jyao1 jyao1 mentioned this issue May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liuw1 liuw1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update stable rust toolchain to 1.60.0 liuw1/td-shim
3 participants
@jyao1 @longlongyang @liuw1