Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

garm: introduce vm_location param #9

Merged

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Feb 1, 2024

the current location (eastus) will only support SEV-SNP and nestable instances, if we want to support TDX runners, we have to move to a region that supports all three of them: westeurope is one of those regions.

Since we don't want to invalidate all the urls in the github webhook configurations when moving to another location (garm urls are bound to a location), a discrete vm_location param has been introduced that configures GARM to spawn Runners in that region.

@mkulke mkulke requested review from wainersm and surajssd February 1, 2024 12:31
@wainersm
Copy link
Member

wainersm commented Feb 1, 2024

Hi @mkulke !

the current location (eastus) will only support SEV-SNP and nestable instances, if we want to support TDX runners, we have to move to a region that supports all three of them: westeurope is one of those regions.

Just curious: do we plans to provision bare-metal machines for TDX runners (or sev/snp)?

Since we don't want to invalidate all the urls in the github webhook configurations when moving to another location (garm urls are bound to a location), a discrete vm_location param has been introduced that configures GARM to spawn Runners in that region.

Checking I got it right: all the other resources, including the group, are going to still live in eastus?

@mkulke
Copy link
Contributor Author

mkulke commented Feb 1, 2024

Just curious: do we plans to provision bare-metal machines for TDX runners (or sev/snp)?

I think we do, but that would not be GARM related, but bare-metal hosts registered as github runners.

Checking I got it right: all the other resources, including the group, are going to still live in eastus?

yup the garm (ACI + storage account etc) resources do still live in eastus.

garm creates a new resource group per runner (with all the suppporting infra, NIC, ip, etc). annoyingly, you cannot configure a location on a per-pool basis, but only globally.

@mkulke mkulke requested a review from wainersm February 1, 2024 13:40
the current location (eastus) will only support SEV-SNP and nestable
instances, if we want to support TDX runners, we have to move to a
region that supports all three of them: westeurope is one of those
regions.

Since we don't want to invalidate all the urls in the github webhook
configurations when moving to another location (garm urls are bound
to a location), a discrete `vm_location` param has been introduced that
configures GARM to spawn Runners in that region.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke force-pushed the mkulke/add-vm-location-param branch from 4ca9887 to beaabde Compare February 1, 2024 13:43
@portersrc
Copy link
Member

lgtm

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkulke !

@wainersm wainersm merged commit 3764ed8 into confidential-containers:main Feb 1, 2024
1 check passed
@mkulke mkulke deleted the mkulke/add-vm-location-param branch February 1, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants