gcp: allow users to set podvm disk-type and align CLI options #2281
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have a strict convention to follow but I'm trying to avoid duplicating gcp- prefix as much as possible, since this is about GCP already. AWS: -imageid Azure: -image-id GCP: -image-name Not perfect, but we are closer to a "common convention" that makes a little bit of sense. "Name" is used instead of "ID" for GCP because "ID" is not commonly used for images in GCP. Signed-off-by: Beraldo Leal <bleal@redhat.com>
Following the previous commit, updated GCP machine type naming for consistency: AWS: -instance-type Azure: -instance-size GCP: -machine-type This keeps GCP in line with its own terminology while aligning CLI options across providers. Signed-off-by: Beraldo Leal <bleal@redhat.com>
Following the previous commits, updated GCP network naming for consistency: AWS: -subnetid Azure: -subnetid GCP: -network The current code uses "network" instead of "subnet," so this change is not about switching to subnet. Keeping "network" for now. Subnet usage will be tested in a separate PR. Signed-off-by: Beraldo Leal <bleal@redhat.com>
Following the previous commits, updated GCP zone naming for consistency: AWS: -aws-region Azure: -region GCP: -zone GCP is using zones instead of regions, since IBM is also without prefix, I'm joing the non-prefix team here. Signed-off-by: Beraldo Leal <bleal@redhat.com>
Currently, the disk type for GCP PodVM creation is hard coded to pd-standard. Fixes confidential-containers#2258. Signed-off-by: Beraldo Leal <bleal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to set the PodVM disk type for GCP instead of using the hardcoded pd-standard.
Also cleaned up some CLI options to be more consistent across providers, by dropping extra gcp- prefix.