test/aws: disable, enable and fix tests #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the creation of a bucket is not idempotent, double-creation has thrown an error. This changed the logic to only try to create it in case it doesn't exists. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
The TestAwsCreatePeerPodContainerWithInvalidAlternateImage has a wrong expected error message. Fixed it. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
The test for ConfigMap is passing, so let's re-enable it. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
The TestAwsCreateNginxDeployment is no longer passing. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
wainersm
force-pushed
the
aws_e2e_for_012
branch
from
272b666 to
7c628f7
Compare
To test init containers on AWS peer pods. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
bpradipt
reviewed
Jan 27, 2025
| @@ -101,13 +101,19 @@ func TestAwsDeletePod(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestAwsCreateNginxDeployment(t *testing.T) { | |||
| t.Skip("Test not passing") | |||
There was a problem hiding this comment.
Hmm, isn't this a basic test? Any idea why is it failing ?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks @wainersm. I was just curious :-) ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes I needed to pass the e2e tests for AWS.