Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caa: Re-add ppc64le support to build #2237

Merged
merged 1 commit into from
Jan 17, 2025
Merged

caa: Re-add ppc64le support to build #2237

merged 1 commit into from
Jan 17, 2025

Conversation

stevenhorsman
Copy link
Member

When the arm support was added in #2194 it seems
to have broken ppc64le builds: e.g.
https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891 so try and fix this

@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Jan 13, 2025
@stevenhorsman
Copy link
Member Author

I tested this on my fork: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/12751593951/job/35539041122 and whilst all the jobs failed with lack of permission to push to quay.io/confidential-containers/cloud-api-adaptor, the build stage did seem to succeed, so I think this PR resolves the issue:

#29 [builder 12/12] RUN CC=gcc make ARCH=ppc64le COMMIT=9d0974f79d725fd017042f51dd1a7b7f3e092fa3 VERSION=v0.8.0-alpha.1-dev RELEASE_BUILD=false cloud-api-adaptor
#29 DONE 1239.7s

@stevenhorsman stevenhorsman marked this pull request as ready for review January 13, 2025 17:00
@stevenhorsman stevenhorsman requested a review from a team as a code owner January 13, 2025 17:00
bpradipt
bpradipt approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xutao323
Copy link
Contributor

Sorry for missing ppc64le support in the #2194, and thanks for the fix.

@wainersm
Copy link
Member

Hi @stevenhorsman !

I tested this on my fork: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/12751593951/job/35539041122 and whilst all the jobs failed with lack of permission to push to quay.io/confidential-containers/cloud-api-adaptor, the build stage did seem to succeed, so I think this PR resolves the issue:

#29 [builder 12/12] RUN CC=gcc make ARCH=ppc64le COMMIT=9d0974f79d725fd017042f51dd1a7b7f3e092fa3 VERSION=v0.8.0-alpha.1-dev RELEASE_BUILD=false cloud-api-adaptor
#29 DONE 1239.7s

I also ran the following command with and without the fix:

ARCHES=linux/ppc64le RELEASE_BUILD=false DEV_TAGS=latest make image-with-arch registry=quay.io/wainersm

Indeed building and pushing the image.

wainersm
wainersm approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenhorsman !

@stevenhorsman
caa: Re-add ppc64le support to build
b01f732 
When the arm support was added in confidential-containers#2194 it seems
to have broken ppc64le builds: e.g.
https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/12747057891
so try and fix this

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman merged commit aaabd4f into confidential-containers:main Jan 17, 2025
43 checks passed
@stevenhorsman stevenhorsman deleted the ppcle64-support-caa branch January 17, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpradipt bpradipt bpradipt approved these changes

@wainersm wainersm wainersm approved these changes

Assignees
No one assigned
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenhorsman @xutao323 @wainersm @bpradipt