ci: install mkosi from repository #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install mkosi from the upstream project to align s390x and amd64 builds. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
wainersm
reviewed
Jan 10, 2025
mkulke
force-pushed
the
mkulke/install-mkosi-from-repo
branch
6 times, most recently
from
dd0eb3f to
3187e27
Compare
|
@stevenhorsman the e2e tests will fail since the workflow and the Makefile were edited |
Good point - can we test (some of it) on a fork repo? |
mkulke
force-pushed
the
mkulke/install-mkosi-from-repo
branch
from
3187e27 to
77652b3
Compare
yup, see PR description |
Sorry! |
more recent version of mkosi can use Profile & Architecture in matches clauses. Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
mkulke
force-pushed
the
mkulke/install-mkosi-from-repo
branch
from
77652b3 to
291e3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the last community call, we can adopt the installation method of the s390x builds and use it also for the amd64 builds. this allows us to use the profile feature available in more recent versions of mkosi and simplify some things.
here would be a successful build on a fork. due to the pull-request-target logic there will be a mismatch between Makefile (on PR branch) and github-actions workflow (on main), so it doesn't make sense to run e2e tests here.