Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: re-order sysctl step for podvm_mkosi wf #2209

Merged

Conversation

mkulke
Copy link
Collaborator

@mkulke mkulke commented Dec 12, 2024

A default directory is set workflow-wide that will only work after checkout, hence the sysctl call fails.

A default directory is set workflow-wide that will only work after
checkout, hence the sysctl call fails.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke requested a review from a team as a code owner December 12, 2024 12:40
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks!

Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mkulke !

@mkulke mkulke merged commit 1079abf into confidential-containers:main Dec 12, 2024
22 checks passed
@mkulke mkulke deleted the mkulke/fix-gh-action-step-ordering branch December 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants