Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: Actually temporarily skip the s390x e2e tests #2191

Merged
merged 1 commit into from
Dec 5, 2024
Merged

workflow: Actually temporarily skip the s390x e2e tests #2191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/e2e_run_all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,12 +266,7 @@ jobs:
libvirt_s390x:
name: E2E tests on libvirt for the s390x architecture
# Skip s390x e2e tests until Choi is available to set-up the s390x runner's pre-action properly. Then revert this.
if: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I reviewed and merged the previous PR without realizing that.

Here you want use 'false &&' to preserve the entire block. Whatever you prefer, I will ack regardless.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, false && was what I should have done originally, but I'm not taking any chance this time!

false ||
github.event_name == 'schedule' ||
github.event_name == 'workflow_dispatch' ||
contains(github.event.pull_request.labels.*.name, 'test_e2e_libvirt') ||
contains(github.event.pull_request.labels.*.name, 'test_e2e_libvirt_s390x')
if: false
needs: [podvm_mkosi_s390x, libvirt_e2e_arch_prep, caa_image_s390x]
strategy:
fail-fast: false
Expand Down
Loading