Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try unskipping the previously flakey libvirt tests to check them #2183

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions src/cloud-api-adaptor/test/e2e/libvirt_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ func TestLibvirtCreateSimplePod(t *testing.T) {
}

func TestLibvirtCreatePodWithConfigMap(t *testing.T) {
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePodWithConfigMap(t, testEnv, assert)
}
Expand Down Expand Up @@ -62,25 +61,16 @@ func TestLibvirtCreatePeerPodAndCheckUserLogs(t *testing.T) {
}

func TestLibvirtCreatePeerPodAndCheckWorkDirLogs(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckWorkDirLogs(t, testEnv, assert)
}

func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageOnly(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckEnvVariableLogsWithImageOnly(t, testEnv, assert)
}

func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly(t, testEnv, assert)
}
Expand All @@ -94,20 +84,15 @@ func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageAndDeployment(t *te
}

func TestLibvirtCreateNginxDeployment(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
// See https://github.com/confidential-containers/cloud-api-adaptor/issues/2046
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestNginxDeployment(t, testEnv, assert)
}

/*
Failing due to issues will pulling image (ErrImagePull)
func TestLibvirtCreatePeerPodWithLargeImage(t *testing.T) {
SkipTestOnCI(t)
assert := LibvirtAssert{}
DoTestCreatePeerPodWithLargeImage(t, testEnv, assert)
}
*/

func TestLibvirtDeletePod(t *testing.T) {
assert := LibvirtAssert{}
Expand All @@ -116,7 +101,6 @@ func TestLibvirtDeletePod(t *testing.T) {

func TestLibvirtPodToServiceCommunication(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
SkipTestOnCI(t)
if isTestOnCrio() {
t.Skip("Fails with CRI-O (confidential-containers/cloud-api-adaptor#2100)")
}
Expand All @@ -126,7 +110,6 @@ func TestLibvirtPodToServiceCommunication(t *testing.T) {

func TestLibvirtPodsMTLSCommunication(t *testing.T) {
// This test is causing issues on CI with instability, so skip until we can resolve this.
SkipTestOnCI(t)
if isTestOnCrio() {
t.Skip("Fails with CRI-O (confidential-containers/cloud-api-adaptor#2100)")
}
Expand Down
Loading