Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemonset: reduce log volume #2159

Conversation

mkulke
Copy link
Collaborator

@mkulke mkulke commented Nov 19, 2024

The probing code regularly produces "ignored pod" log lines. For clusters with a lot of pods this is quite excessive and noisy.

drive-by fix: use early returns to reduce deep nesting in that part of the code.

The probing code regularly produces "ignored pod" log lines. For
clusters with a lot of pods this is quite excessive and noisy.

drive-by fix: use early returns to reduce deep nesting in that part of the
code.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke requested a review from a team as a code owner November 19, 2024 10:26
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mkulke mkulke merged commit a22b492 into confidential-containers:main Nov 19, 2024
19 checks passed
@mkulke mkulke deleted the mkulke/remove-noisy-pod-probing-log branch November 19, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants