Enable pod VM image selection via pod annotation #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows using a different AMI than the default configured. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Enables using a different image than the one configured. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Allows using a different docker image than the default configured. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Allows using a different GCP image than the default configured. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Aligning the variable name to other providers to be consistent. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Allows using a different PowerVS image than the default configured. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Ensure the image and expected error message is customisable as it's different for every provider and makes it easier to reuse for other providers Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
This is a negative test to ensure the functionality of picking up the AMI from pod annotation works. This doesn't need any AMI to exist in the region and makes it easier to test in CI. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
bpradipt
force-pushed
the
multiple-images
branch
from
0353949 to
301553c
Compare
snir911
approved these changes
Nov 17, 2024
This can be done at containerd/crio or in configuration.toml, like any other Kata hypervisor annotations. I don't think it makes sense to duplicate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.