Misc security related fixes for AWS and Azure #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS expects VolumeSize to be int32, however the Golang flags package only provides IntVar. So add checks to prevent overflow Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Ensure to clean the SSH key path and also verify to ensure the file has proper permission and the public key is in the proper format, avoiding any spurious entries via the key file. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
mkulke
reviewed
Nov 4, 2024
|
|
||
| // Verify SSH public key file | ||
| // Check the permissions and the content of the file to ensure it is a valid SSH public key | ||
| func VerifySSHKeyFile(sshKeyFile string) error { |
There was a problem hiding this comment.
with the change to mkosi images, we won't have the option to provision SSH keys anymore, since this functionality relies on cloud-init and writeable root filesystems
There was a problem hiding this comment.
True for CoCo and that's why I added it to the ConfigVerifier method which is disabled by default. For non CoCo (regular peer-pods) this at least gives an option to ensure using valid public key. Is that acceptable ?
mkulke
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws: Avoid integer overflow when processing RootVolumeSize
azure: Verify the SSH key to ensure the file is using a supported public key format