Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: Fix kustomize permission issue #2111

Conversation

stevenhorsman
Copy link
Member

  • Use Wainer's suggested approach of sudo bash -s rather than the separate install
  • Also update Azure's e2e workflow with the fix

libvirt tested with forked workflow: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11295615233/job/31418883368

- Use Wainer's suggested approach of `sudo bash -s` rather
than the separate install
- Also update Azure's e2e workflow with the fix

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman requested a review from a team as a code owner October 11, 2024 16:15
Copy link
Collaborator

@mkulke mkulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curiously the azure job succeeded anyway, I suppose the user on github-runners has access to /usr/local/bin

Copy link
Contributor

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@stevenhorsman stevenhorsman merged commit d3ad603 into confidential-containers:main Oct 14, 2024
19 checks passed
@stevenhorsman stevenhorsman deleted the azure-kustomize-install-fix branch October 14, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants