csi-wrapper: pass PublishContext from ControllerPublishVolume to NodeStageVolume
#2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoheiueda - are you able to review this when you get a chance as I think you worked on the csi-wrapper feature? |
daniel-weisse
force-pushed
the
keep-publish-context
branch
from
c3f5fa9 to
e64346c
Compare
yoheiueda
reviewed
Oct 16, 2024
daniel-weisse
force-pushed
the
keep-publish-context
branch
from
df2a207 to
ae16997
Compare
daniel-weisse
force-pushed
the
keep-publish-context
branch
2 times, most recently
from
abfdb50 to
1557eb4
Compare
When reproducing `NodeStageVolume` for the pod VM, pass the `PublishContext` of the reproduced `ControllerPublishVolume` to the `NodeStageVolumeRequest` of the Pod VM. Signed-off-by: Daniel Weiße <dw@edgeless.systems>
…lume The fake information should never be needed by the CSI driver, but may potentially cause issues if the driver performs strict checking on its input values Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
keep-publish-context
branch
from
1557eb4 to
416a3b4
Compare
katexochen
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CSI driver may rely on the output of
ControllerPublishVolumeduring theNodeStageVolumecall.Since the csi-wrapper simply creates a fake
ControllerPublishVolumeResponse, information may be lost between the two calls.Since the peerpod volume caches the real response, we can use this during the wrapper's
NodeStageVolumeto supply the driver with the real values.