csi-wrapper: add support for creating peerpod volumes with manually created persistent volumes #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoheiueda - are you able to review this when you get a chance as I think you worked on the csi-wrapper feature? |
daniel-weisse
force-pushed
the
existing-pv
branch
from
1576d19 to
246b3c9
Compare
yoheiueda
reviewed
Oct 16, 2024
daniel-weisse
force-pushed
the
existing-pv
branch
2 times, most recently
from
3876e8a to
3a832cd
Compare
To support usage of manually created persistent volumes, a peerpod volume CR needs to be created during `ControllerPublishVolume`, Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
existing-pv
branch
from
3a832cd to
274b726
Compare
katexochen
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peerpod volume custom resource is currently only created during the
CreateVolumerpc of the controller service.This endpoint is called by Kubernetes during the creation of a persistent volume claim (PVC) without an already existing persistent volume (PV).
All subsequent controller, node, and podvm csi-wrapper endpoints that interact with peerpod volumes CRs (e.g.
ControllerPublishVolume) now assume that a peerpod volume already exists.However, this is not the case if a PVC with a manually created, or already existing, PV is created.
This is required when statically provisioning a volume, for example, by the azuredisk-csi-driver to consume a pre-existing disk through a PVC.
When a PV already exists, the
CreateVolumeendpoint is never called, and we directly go toControllerPublishVolumeinstead.This PR aims to fix this problem by performing an check during
ControllerPublishVolumeif there is no matching peerpod volume found.Since the information we get during
ControllerPublishVolumeis a lot more limited than what we get duringCreateVolume, a little workaround is needed.Mainly, we don't have access to the
Parametersfield of the PVC, which we use duringCreateVolumeto discern if a peerpod volume should be created, by checking if it contains the keypeerpod.So instead, we rely on the user to set the
peerpodkey in theVolumeContextfield of the manually created PV.A second issue is that we don't have access to the
VolumeNameof the PVC duringControllerPublishVolume.This value is checked for comparison during
NodePublishVolumeto ensure the peerpod volume matches the "real" volume to publish.We side steps this issue by setting a placeholder name during
ControllerPublishVolume, and if this placeholder is set duringNodePublishVolume, replace it with the real value.