workflows: Install gh cli on self-hosted runner #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
approved these changes
Oct 10, 2024
In confidential-containers#2077 I forgot about pull_request_target not testing workflows in PRs and that self-hosted runners wouldn't have the gh cli installed, so this attempts to fix the workflows and install gh cli first. I also set `GH_TOKEN` env in the step that uses `gh` based on the `gh help environment` doc that states: GH_TOKEN: an authentication token for github.com API requests. Setting this avoids being prompted to authenticate. Note: I did find a few actions to do this, but they were only used by single digit projects, so I figured it would be safer to do it ourselves for now Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
force-pushed
the
intall-gh-in-workflows
branch
from
26259cb to
78ad550
Compare
wainersm
reviewed
Oct 10, 2024
| @@ -117,6 +121,8 @@ jobs: | |||
| # For debugging | |||
| ls ./target/release | |||
| popd | |||
| env: | |||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
Really interesting that gh doesn't read from GITHUB_TOKEN. Never used that tool much so don't know for sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2077 I forgot about pull_request_target not testing workflows in PRs and that self-hosted runners wouldn't have the gh cli installed, so this attempts to fix the workflows and install gh cli first.
I also set
GH_TOKENenv in the step that usesghbased on thegh help environmentdoc that states:GH_TOKEN: an authentication token for github.com API requests. Setting this avoids being prompted to authenticate.
Hopefully this is enough to get us back passing.
Note: I did find a few actions to do this, but they were only used by single digit projects, so I figured it would be safer to do it ourselves for now
Disclaimer: This assumes that
secrets.GITHUB_TOKENis created for self-hosted runners, which some guides hint is true, but I can't find concrete GitHub doc of this .