ci: fix azure nightly mkosi build #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a rebase fail, the workflow attempted to use the ubuntu mkosi build. Reverted to building using nix to stay close to the documented procedure. If we opt to use the ubuntu-packaged mkosi, more testing is required and we should change it everywhere. In the mid-term this makes sense, because currently mkosi is marked as broken in nixos-24.05 and nix-unstable. the version we have pinned in the nix flake (v17) is rather old now. Drive-by fix: sudo is not required for mkosi images on Ubuntu 22.04 Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
stevenhorsman
approved these changes
Oct 8, 2024
mkulke
added
CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a rebase fail, the workflow attempted to use the ubuntu mkosi build. Reverted to building using nix to stay close to the documented procedure. If we opt to use the ubuntu-packaged mkosi, more testing is required and we should change it everywhere.
In the mid-term this would make sense, because currently mkosi is marked as broken in nixos-24.05 and nix-unstable. the version we have pinned in the nix flake (v17) is rather old now.
Drive-by fix: sudo is not required for mkosi images on Ubuntu 22.04