Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Increase libvirt e2e test timeout #2040

Conversation

stevenhorsman
Copy link
Member

We've seen a few nightly and PR test runs fail due to e2e timeout. Looking into it our timeout for over a year has been fixed at 50m, but in that time we've added a lot of tests and do extra deployment stages, like trustee. Looking at a recently run around half of the 50m allowance was taking up just setting up the cluster before tests run. Whilst I think it would be good to try and refine/filter the tests we run and improve some of the slowness, in the short term increasing the timeout will help us avoid e2e failures and re-runs.

We've seen a few nightly and PR test runs fail due to e2e timeout.
Looking into it our timeout for over a year has been fixed at 50m, but
in that time we've added a lot of tests and do extra deployment stages,
like trustee. Looking at a recently run around half of the 50m allowance
was taking up just setting up the cluster before tests run. Whilst I think
it would be good to try and refine/filter the tests we run and improve some
of the slowness, in the short term increasing the timeout will help us avoid
e2e failures and re-runs.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevenhorsman stevenhorsman merged commit b7fef96 into confidential-containers:main Sep 16, 2024
19 checks passed
@stevenhorsman stevenhorsman deleted the libvirt-timeout-increase branch September 16, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants