Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kata 3.8.0 versions bump #2017

Conversation

stevenhorsman
Copy link
Member

@stevenhorsman stevenhorsman commented Aug 27, 2024

Bump components to sync with kata v3.8.0 release to try and ensure we stay up-to-date (ish)

@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Aug 27, 2024
@stevenhorsman stevenhorsman force-pushed the kata-3.8.0-versions-bump branch from e5f365a to d7a31a2 Compare August 27, 2024 12:49
@stevenhorsman
Copy link
Member Author

It looks like libsecomp from kata-containers is causing the License failure as it's LGPL-2.1. I'm not sure why Magnus' previous ignore for this isn't working - maybe it was for a specific version? I tried to add my own matching ignore rule and I got a permission error.

@stevenhorsman stevenhorsman force-pushed the kata-3.8.0-versions-bump branch from d7a31a2 to a2a294c Compare September 4, 2024 14:48
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -45,11 +45,11 @@ git:
reference: v1.5.0
kbs:
url: https://github.com/confidential-containers/trustee
reference: e890fc90c384207668fa3a4d6a2f2a2d652797ee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stevenhorsman !

e890f is the trustee version used on kata's 3.8.0 (https://github.com/kata-containers/kata-containers/blob/3.8.0/versions.yaml#L237). Do we need a new version? that's why this update?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry, this change was reverted: kata-containers/kata-containers#10178, so I'm not sure why I picked the wrong one. I'll revert this, Thanks!

- Bump the agent to come from v3.8.0 release
- Match the trustee and guest-components to match the
versions file in that release as well

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- Update the kata-containers/runtime go module
to match the v3.8.0 release

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman stevenhorsman force-pushed the kata-3.8.0-versions-bump branch from a2a294c to ab39bc5 Compare September 9, 2024 14:42
Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenhorsman !

@stevenhorsman stevenhorsman merged commit a4d4917 into confidential-containers:main Sep 9, 2024
26 of 27 checks passed
@stevenhorsman stevenhorsman deleted the kata-3.8.0-versions-bump branch October 3, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants