-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kata 3.8.0 versions bump #2017
Kata 3.8.0 versions bump #2017
Conversation
e5f365a
to
d7a31a2
Compare
It looks like libsecomp from kata-containers is causing the License failure as it's LGPL-2.1. I'm not sure why Magnus' previous ignore for this isn't working - maybe it was for a specific version? I tried to add my own matching ignore rule and I got a permission error. |
d7a31a2
to
a2a294c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
src/cloud-api-adaptor/versions.yaml
Outdated
@@ -45,11 +45,11 @@ git: | |||
reference: v1.5.0 | |||
kbs: | |||
url: https://github.com/confidential-containers/trustee | |||
reference: e890fc90c384207668fa3a4d6a2f2a2d652797ee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stevenhorsman !
e890f is the trustee version used on kata's 3.8.0 (https://github.com/kata-containers/kata-containers/blob/3.8.0/versions.yaml#L237). Do we need a new version? that's why this update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sorry, this change was reverted: kata-containers/kata-containers#10178, so I'm not sure why I picked the wrong one. I'll revert this, Thanks!
- Bump the agent to come from v3.8.0 release - Match the trustee and guest-components to match the versions file in that release as well Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- Update the kata-containers/runtime go module to match the v3.8.0 release Signed-off-by: stevenhorsman <steven@uk.ibm.com>
a2a294c
to
ab39bc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stevenhorsman !
a4d4917
into
confidential-containers:main
Bump components to sync with kata v3.8.0 release to try and ensure we stay up-to-date (ish)