Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initdata: don't fail process-user-data if absent #1994

Conversation

mkulke
Copy link
Collaborator

@mkulke mkulke commented Aug 9, 2024

currently the process-user-data unit will fail because process-user-data will exit with a non-zero exit code if there is no initdata file on the file system. this PR will skip the initdata processing with a log message and exit successfully in such a case.

currently the process-user-data unit will fail because process-user-data
will exit with a non-zero exit code if there is no initdata file on the
file system. this PR will skip the initdata processing with a log message
and exit successfully in such a case.

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke changed the title initdata: don't fail process-user-data when absent initdata: don't fail process-user-data if absent Aug 9, 2024
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@mkulke mkulke merged commit 50255a7 into confidential-containers:main Aug 9, 2024
20 checks passed
@mkulke mkulke deleted the mkulke/dont-fail-on-missing-initdata branch August 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants